Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for hr raw exporter and astral clock to bangle.js 2 #3049

Merged
merged 18 commits into from
Oct 27, 2023

Conversation

jabituyaben
Copy link
Contributor

added support for hr raw exporter to bangle.js 2

@jabituyaben jabituyaben changed the title added support for hr raw exporter to bangle.js 2 added support for hr raw exporter and astral clock to bangle.js 2 Oct 16, 2023
@gfwilliams
Copy link
Member

Hi - thanks for this - but looking at the astral clock changes, haven't you just broken it for Bangle.js 1?

Bangle.js 1 touchscreen only supports left/right swipes (no up/down) so as far as I can see this would no longer be usable on it? You could try with the emulator to check.

Maybe you should check if it's Bangle.js 1/2 and then then choose whether to do swipes or button presses?

OR you could do Bangle.setUI({mode:"clockupdown"}) (https://www.espruino.com/Reference#l_Bangle_setUI) which automatically uses either taps or button presses depending on which device is used.

@jabituyaben
Copy link
Contributor Author

Hi - thanks for this - but looking at the astral clock changes, haven't you just broken it for Bangle.js 1?

Bangle.js 1 touchscreen only supports left/right swipes (no up/down) so as far as I can see this would no longer be usable on it? You could try with the emulator to check.

Maybe you should check if it's Bangle.js 1/2 and then then choose whether to do swipes or button presses?

OR you could do Bangle.setUI({mode:"clockupdown"}) (https://www.espruino.com/Reference#l_Bangle_setUI) which automatically uses either taps or button presses depending on which device is used.

Good spot - I've sorted this by checking which version of the Bangle it is and adding button function for Bangle 1. Also added note that it currently only supports the dark background mode for Bangle 2 at the moment.

@gfwilliams
Copy link
Member

Looks great - thanks for making that change!

@gfwilliams gfwilliams merged commit fbfb087 into espruino:master Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants