Skip to content

Conversation

@Hahihula
Copy link
Collaborator

EIM-419 Added python 3.14 to a list of supported python versions for linux and macos systems but not for windows

@gemini-code-assist
Copy link

Summary of Changes

Hello @Hahihula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the application's compatibility by introducing support for Python 3.14 on Linux and macOS operating systems. It refines the Python version validation logic to differentiate support based on the operating system, ensuring that Windows environments continue to adhere to the existing version constraints. The changes also include an update to the internal list of explicitly supported Python versions to reflect this new compatibility.

Highlights

  • Conditional Python 3.14 Support: Python 3.14 is now recognized as a supported version for Linux and macOS systems within the python_sanity_check function.
  • Windows Exclusion for Python 3.14: Python 3.14 remains explicitly unsupported for Windows environments, maintaining the previous version requirement of <3.14.0.
  • Updated Supported Versions List: The global SUPPORTED_PYTHON_VERSIONS constant array has been updated to include '3.14'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Python 3.14 on Linux and macOS, which aligns with the stated goal. The changes are logical, but I've identified a couple of areas for improvement. Specifically, I've suggested refactoring a block of code to reduce duplication and improve maintainability, and I've also pointed out a minor formatting issue that can enhance code readability.

Comment on lines +828 to 845
let req = match std::env::consts::OS {
"windows" => VersionReq::parse(">=3.10.0, <3.14.0").unwrap(),
_ => VersionReq::parse(">=3.10.0, <3.15.0").unwrap(),
};
if req.matches(&version) {
outputs.push(Ok(format!("Python version {} is supported", version)));
} else {
outputs.push(Err(format!(
match std::env::consts::OS {
"windows" => outputs.push(Err(format!(
"Python version {} is not supported. Required: >=3.10.0, <3.14.0",
version
)));
))),
_ => outputs.push(Err(format!(
"Python version {} is not supported. Required: >=3.10.0, <3.15.0",
version
))),
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block contains duplicated logic. The OS check is performed twice, and the version requirement strings are repeated. You can refactor this to determine the requirement string once and reuse it, which improves readability and maintainability.

                    let req_str = if std::env::consts::OS == "windows" {
                        ">=3.10.0, <3.14.0"
                    } else {
                        ">=3.10.0, <3.15.0"
                    };
                    let req = VersionReq::parse(req_str).unwrap();
                    if req.matches(&version) {
                        outputs.push(Ok(format!("Python version {} is supported", version)));
                    } else {
                        outputs.push(Err(format!(
                            "Python version {} is not supported. Required: {}",
                            version, req_str
                        )));
                    }


pub const PYTHON_VERSION: &str = "3.11";
pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13"];
pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13","3.14"];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to follow common Rust formatting conventions, please add a space after the comma separating the items in the array.

Suggested change
pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13","3.14"];
pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13", "3.14"];

@Hahihula Hahihula force-pushed the EIM-419-python-version-gating branch from 31efebc to 8201fbf Compare January 20, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants