-
Notifications
You must be signed in to change notification settings - Fork 4
EIM-419 Added python 3.14 to a list of supported python versions #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Hahihula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the application's compatibility by introducing support for Python 3.14 on Linux and macOS operating systems. It refines the Python version validation logic to differentiate support based on the operating system, ensuring that Windows environments continue to adhere to the existing version constraints. The changes also include an update to the internal list of explicitly supported Python versions to reflect this new compatibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14 on Linux and macOS, which aligns with the stated goal. The changes are logical, but I've identified a couple of areas for improvement. Specifically, I've suggested refactoring a block of code to reduce duplication and improve maintainability, and I've also pointed out a minor formatting issue that can enhance code readability.
| let req = match std::env::consts::OS { | ||
| "windows" => VersionReq::parse(">=3.10.0, <3.14.0").unwrap(), | ||
| _ => VersionReq::parse(">=3.10.0, <3.15.0").unwrap(), | ||
| }; | ||
| if req.matches(&version) { | ||
| outputs.push(Ok(format!("Python version {} is supported", version))); | ||
| } else { | ||
| outputs.push(Err(format!( | ||
| match std::env::consts::OS { | ||
| "windows" => outputs.push(Err(format!( | ||
| "Python version {} is not supported. Required: >=3.10.0, <3.14.0", | ||
| version | ||
| ))); | ||
| ))), | ||
| _ => outputs.push(Err(format!( | ||
| "Python version {} is not supported. Required: >=3.10.0, <3.15.0", | ||
| version | ||
| ))), | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block contains duplicated logic. The OS check is performed twice, and the version requirement strings are repeated. You can refactor this to determine the requirement string once and reuse it, which improves readability and maintainability.
let req_str = if std::env::consts::OS == "windows" {
">=3.10.0, <3.14.0"
} else {
">=3.10.0, <3.15.0"
};
let req = VersionReq::parse(req_str).unwrap();
if req.matches(&version) {
outputs.push(Ok(format!("Python version {} is supported", version)));
} else {
outputs.push(Err(format!(
"Python version {} is not supported. Required: {}",
version, req_str
)));
}|
|
||
| pub const PYTHON_VERSION: &str = "3.11"; | ||
| pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13"]; | ||
| pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13","3.14"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to follow common Rust formatting conventions, please add a space after the comma separating the items in the array.
| pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13","3.14"]; | |
| pub const SUPPORTED_PYTHON_VERSIONS: &[&str] = &["3.10", "3.11", "3.12", "3.13", "3.14"]; |
…inux and macos systems but not for windows
31efebc to
8201fbf
Compare
EIM-419 Added python 3.14 to a list of supported python versions for linux and macos systems but not for windows