Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idf): Add support for IDF v5.4 (#10823) #10832

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

me-no-dev
Copy link
Member

This PR holds the changes necessary to prepare v3.2.0 on top of ESP-IDF v5.4

@me-no-dev me-no-dev added the 🚫 System PR Pull requests for internal use or lib updates label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 115caf2

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Results

62 files  62 suites   1h 26m 42s ⏱️
 9 tests  2 ✅ 0 💤  7 ❌
63 runs   2 ✅ 0 💤 61 ❌

For more details on these failures, see this check.

Results for commit 115caf2.

♻️ This comment has been updated with latest results.

me-no-dev and others added 7 commits January 10, 2025 14:05
* feat(i2c): Add support for the new I2C driver in IDF v5.4

* fix(build): Add the new driver to CMakeLists.txt

* fix(i2c): Guard sleep retention

Not all chips can restore I2C bus after light sleep

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 System PR Pull requests for internal use or lib updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant