Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lisätään lasten laskennallinen määrä yksikön viikokalenteriin #6243

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

patari
Copy link
Collaborator

@patari patari commented Jan 14, 2025

"Lapsia läsnä"-sarakkeeseen laskennallinen määrä nuppiluvun yhteyteeen.

@patari patari added the enhancement Uusi toiminnallisuus tai parannus label Jan 14, 2025
@patari patari force-pushed the unit-week-calendar-occupancy branch from 22ad005 to 4239d81 Compare January 14, 2025 12:03
[days, selectedGroup, childBasics]
})
.map((child) => child.childId)
const occupancy = childBasics.reduce((occupancy, child) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calculation could be done in the backend. Also family daycare (perhepäivähoito) has different calculation rules.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

family daycare (perhepäivähoito) has different calculation rules

Yeah, forgot that.

Moving calculation to backend needs major changes, because currently a lot is happening in frontend.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@patari patari marked this pull request as draft January 16, 2025 13:59
@patari patari force-pushed the unit-week-calendar-occupancy branch from 4239d81 to 1149a88 Compare January 20, 2025 12:18
@patari patari force-pushed the unit-week-calendar-occupancy branch from 1149a88 to 1bcdd74 Compare January 20, 2025 13:32
@patari patari marked this pull request as ready for review January 20, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Uusi toiminnallisuus tai parannus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants