Tools - makecorever.py explicit output argument#9248
Merged
mcspr merged 5 commits intoesp8266:masterfrom May 27, 2025
Merged
Conversation
Don't hide where the file is actually placed Using pathlib instead of raw strings to simplify path ops Plus, add stdout preview when output is missing Clean-up git-describe <-> version availility checks
This was referenced May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't hide where the file is actually placed
Using pathlib instead of raw strings to simplify path ops and replace with stdout preview when output string is missing
Clean-up git-describe <-> version availability checks and make sure to handle the case when RELEASE was attempted with a HEAD after tag
current tests/device/Makefile & arduino-cli breaks caching in various ways
one issue is with core_version.h recipe, that either has to be removed or provided at an explicit shared -I... path. because build-path is dependent on the sketch, core.a would always be rebuilt
still providing valid core_version.h also seems more sensible than generating it in the tree / using default 0.0.0