-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add 2023-11-30 meeting notes #472
Conversation
notes/2023/2023-11-30.md
Outdated
| [Change default rule schema to `schema: []` and drop support for function-style rules](https://github.com/eslint/eslint/issues/14709) | @mdjermanovic opened [draft PR](https://github.com/eslint/eslint/pull/17792) | | | ||
| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | | | ||
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon | | ||
| [Implement Language Plugins](https://github.com/eslint/eslint/issues/16999) | Once [#17698](https://github.com/eslint/eslint/pull/17698) and [#143](https://github.com/eslint-community/eslint-plugin-n/issues/143) are merged, we can move this one to ready to merge | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this look correct to you? I was a bit lost on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait to leave an update on the issue till this is more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite there. eslint/eslint#17698 is ready for review, but we can't merge until eslint-community/eslint-plugin-n#143 is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected.
| [Change Request: Enable `reportUnusedDisableDirectives` config option by default](https://github.com/eslint/eslint/issues/15466) | Waiting on @bmish to finish up the [PR (draft)](https://github.com/eslint/eslint/pull/17212) | | | ||
| | | | | ||
|
||
### [Contributor Pool for November](https://github.com/issues?q=org%3Aeslint+label%3A%22contributor+pool%22+merged%3A2023-11-01..2023-11-30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you've told me to begin adding the contributor pool to this file? If not, let me know and I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you!
As requested I'm going to update each mentioned issue next. Also, there were no issues label with |
notes/2023/2023-11-30.md
Outdated
| [Change Request: Remove all formatters except stylish, html, json, and json-with-meta](https://github.com/eslint/eslint/issues/17524) | Waiting on the last remaining changes from @mdjermanovic | | | ||
| [Change default rule schema to `schema: []` and drop support for function-style rules](https://github.com/eslint/eslint/issues/14709) | @mdjermanovic opened [draft PR](https://github.com/eslint/eslint/pull/17792) | | | ||
| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | | | ||
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready for review or ready to implement? Issue status says "ready to implement" and the PR linked to this issue is in draft.
Let me know and I'll update the status of the issue if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status should be "Implementing" 👍 Thanks for catching that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected and updated the status on the issue itself.
| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | | | ||
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon | | ||
| [Implement Language Plugins](https://github.com/eslint/eslint/issues/16999) | Once [#17698](https://github.com/eslint/eslint/pull/17698) and [#143](https://github.com/eslint-community/eslint-plugin-n/issues/143) are merged, we can move this one to ready to merge | | | ||
| [Implement Flat Config](https://github.com/eslint/eslint/issues/13481) | **Blocked** | Blocked by work left on getting the rule tests switched over to use `FlatRuleTester`. Once that's merged, @nzakas will start on the docs. Also, we won't rename files in this PR. It will be handle separately. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are disabled for this issue so won't be able to leave an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is weird...as a team member I thought you should be able to do leave a comment still. I'll look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discord is intentionally set up that way. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so you have "triage" permissions on the repo and apparently that wasn't enough. I've bumped that up to "write" permissions. Can you see if that works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-authored-by: Milos Djermanovic <[email protected]>
Closes #470