Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add 2023-11-30 meeting notes #472

Merged
merged 3 commits into from
Dec 7, 2023
Merged

docs: Add 2023-11-30 meeting notes #472

merged 3 commits into from
Dec 7, 2023

Conversation

sam3k
Copy link
Contributor

@sam3k sam3k commented Dec 1, 2023

Closes #470

| [Change default rule schema to `schema: []` and drop support for function-style rules](https://github.com/eslint/eslint/issues/14709) | @mdjermanovic opened [draft PR](https://github.com/eslint/eslint/pull/17792) | |
| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | |
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon |
| [Implement Language Plugins](https://github.com/eslint/eslint/issues/16999) | Once [#17698](https://github.com/eslint/eslint/pull/17698) and [#143](https://github.com/eslint-community/eslint-plugin-n/issues/143) are merged, we can move this one to ready to merge | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look correct to you? I was a bit lost on this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait to leave an update on the issue till this is more clear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite there. eslint/eslint#17698 is ready for review, but we can't merge until eslint-community/eslint-plugin-n#143 is complete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

| [Change Request: Enable `reportUnusedDisableDirectives` config option by default](https://github.com/eslint/eslint/issues/15466) | Waiting on @bmish to finish up the [PR (draft)](https://github.com/eslint/eslint/pull/17212) | |
| | | |

### [Contributor Pool for November](https://github.com/issues?q=org%3Aeslint+label%3A%22contributor+pool%22+merged%3A2023-11-01..2023-11-30)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you've told me to begin adding the contributor pool to this file? If not, let me know and I'll remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!

@sam3k
Copy link
Contributor Author

sam3k commented Dec 1, 2023

As requested I'm going to update each mentioned issue next. Also, there were no issues label with tsc-agenda this time.

| [Change Request: Remove all formatters except stylish, html, json, and json-with-meta](https://github.com/eslint/eslint/issues/17524) | Waiting on the last remaining changes from @mdjermanovic | |
| [Change default rule schema to `schema: []` and drop support for function-style rules](https://github.com/eslint/eslint/issues/14709) | @mdjermanovic opened [draft PR](https://github.com/eslint/eslint/pull/17792) | |
| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | |
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review or ready to implement? Issue status says "ready to implement" and the PR linked to this issue is in draft.

Let me know and I'll update the status of the issue if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status should be "Implementing" 👍 Thanks for catching that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected and updated the status on the issue itself.

| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | |
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon |
| [Implement Language Plugins](https://github.com/eslint/eslint/issues/16999) | Once [#17698](https://github.com/eslint/eslint/pull/17698) and [#143](https://github.com/eslint-community/eslint-plugin-n/issues/143) are merged, we can move this one to ready to merge | |
| [Implement Flat Config](https://github.com/eslint/eslint/issues/13481) | **Blocked** | Blocked by work left on getting the rule tests switched over to use `FlatRuleTester`. Once that's merged, @nzakas will start on the docs. Also, we won't rename files in this PR. It will be handle separately. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are disabled for this issue so won't be able to leave an update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird...as a team member I thought you should be able to do leave a comment still. I'll look into this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see:
Screenshot 2023-12-05 at 7 52 32 PM

Btw, it is the same case with Discord's tsc-meeting channel. I cannot comment or react to a comment. I can only react to someone's else reactions. In case it seems I'm very quiet when I do attend. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord is intentionally set up that way. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so you have "triage" permissions on the repo and apparently that wasn't enough. I've bumped that up to "write" permissions. Can you see if that works?

@sam3k sam3k requested a review from nzakas December 6, 2023 01:00
@sam3k
Copy link
Contributor Author

sam3k commented Dec 6, 2023

@nzakas, addressed all points.

nzakas
nzakas previously approved these changes Dec 6, 2023
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Co-authored-by: Milos Djermanovic <[email protected]>
@nzakas nzakas merged commit 7cb187a into eslint:main Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSC meeting 30-November-2023
3 participants