Skip to content

Commit

Permalink
Update notes/2024/2024-10-31.md
Browse files Browse the repository at this point in the history
  • Loading branch information
mdjermanovic authored Nov 7, 2024
1 parent b8285f4 commit 7f620f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion notes/2024/2024-10-31.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ This PR is ready for review

### [Bug: require-atomic-updates false negative when accessing `this`](https://github.com/eslint/eslint/issues/19022)

It seems that this is excepted from the rule, and the question is whether or not that should be the case. If not, should it be a change of default or a new option? This is a valid request. But given that the way this rule works with properties is "controversial" (there were many reports for false positives) and the complexity required to support this (as it's not handled by scope manager) We're 50/50 on `accepting/wontfix`. If we do accept, it should be behind an option.
It seems that this is excepted from the rule, and the question is whether or not that should be the case. If not, should it be a change of default or a new option? This is a valid request. But given that the way this rule works with properties is "controversial" (there were many reports for false positives) and the complexity required to support `this` (as it's not handled by scope manager) we're 50/50 on `accepting/wontfix`. If we do accept, it should be behind an option.

**Resolution:** we've decided to close as wontfix.

Expand Down

0 comments on commit 7f620f8

Please sign in to comment.