Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @types/eslint to v9 #94

Merged
merged 3 commits into from
Jul 29, 2024
Merged

chore: upgrade @types/eslint to v9 #94

merged 3 commits into from
Jul 29, 2024

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Jul 27, 2024

Prerequisites checklist

What is the purpose of this pull request?

This PR upgrades @types/eslint to the last version for ESLint v9. @types/eslint is only included in devDependencies which makes this change a chore, even if the eslint types are referenced in the published type declarations of @eslint/compat and @eslint/migrate-config.

What changes did you make? (Give an overview)

  • Updated the @eslint/types dependencies to "^9.6.0".
  • Updated a type import in compat package to work with both the v8 and v9 types.
  • Replaced Config with LegacyConfig in migrate-config package to work with both the v8 and v9 types.
  • Excluded c8-generated coverage directories from linting with eslint.

Related Issues

Is there anything you'd like reviewers to focus on?

@fasttime fasttime marked this pull request as ready for review July 27, 2024 10:37
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll leave it open in case someone else wants to review it.

Copy link
Member

@harish-sethuraman harish-sethuraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 0f0fb92 into main Jul 29, 2024
14 checks passed
@nzakas nzakas deleted the types-eslint-v9 branch July 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants