Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: maintenance update of globals to v14 #152

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

voxpelli
Copy link
Contributor

The one breaking change is the dropping of old Node.js versions – but it still support all versions that @eslint/eslintrc supports.

The one impactful change is the removal of its only dependency, making it zero dependency. It replaces an outdated type-fest module with built-in types, which eg makes it so that everyone who installs eslint doesn't have to contend with an outdated type-fest in their npm deduping and hoisting.

Relevant PR: sindresorhus/globals#209

Full release notes: v14.0.0

Only breaking change is the dropping of old Node.js versions but it still support all versions that `@eslint/eslintrc` supports.

The one impactful thing it does though is that it removes the only dependency – replacing an outdated `type-fest` module with built-in types – making it so that everyone that installs `eslint` doesn't also get an outdated `type-fest` and thus doesn't have to contend with it in their `npm` deduping and hoisting.

Relevant PR: sindresorhus/globals#209
@eslint-github-bot
Copy link

Hi @voxpelli!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@voxpelli voxpelli changed the title Maintenance update of globals to v14 fix: maintenance update of globals to v14 Feb 12, 2024
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Feb 12, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like @nzakas to confirm.

@voxpelli voxpelli changed the title fix: maintenance update of globals to v14 chore: maintenance update of globals to v14 Feb 12, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 4151865 into eslint:main Feb 12, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants