Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude private sponsors from list #454

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: Exclude private sponsors from list #454

merged 2 commits into from
Jul 26, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 25, 2023

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

A few months ago we noticed that private sponsorships were being shown on the website. At the time, GitHub didn't have a way to filter out private sponsorships and also didn't provide any way to tell if a sponsorship was private, so we couldn't do anything about it.

I just received word that they have added in the ability to filter out private sponsorships and so I updated fetch-sponsors.js to do that.

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jul 25, 2023
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/64bfeb89979e610008fc7f3c
😎 Deploy Preview https://deploy-preview-454--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/64bfeb897450ee0007669cbd
😎 Deploy Preview https://deploy-preview-454--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/64bfeb8987f12b0008cc232d
😎 Deploy Preview https://deploy-preview-454--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/64bfeb895c70a10008ac8fe1
😎 Deploy Preview https://deploy-preview-454--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/64bfeb89ca9ebf00083ebbe1
😎 Deploy Preview https://deploy-preview-454--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/64bfeb89be3e3a0008519fc0
😎 Deploy Preview https://deploy-preview-454--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/64bfeb89c58bc00008c47056
😎 Deploy Preview https://deploy-preview-454--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 750a95f
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/64bfeb89a4fcf20008a3f060
😎 Deploy Preview https://deploy-preview-454--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving this open for anyone else to review before merging this.

@aladdin-add aladdin-add merged commit 916bfc9 into main Jul 26, 2023
34 checks passed
@aladdin-add aladdin-add deleted the private-sponsors branch July 26, 2023 05:47
nzakas added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants