Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

chore: standardize npm script names #55

Merged
merged 3 commits into from
Aug 7, 2023
Merged

chore: standardize npm script names #55

merged 3 commits into from
Aug 7, 2023

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Refers eslint/eslint#14827

What changes did you make? (Give an overview)

This updates the names of the scripts in package.json to be consistent with the new standard.

Is there anything you'd like reviewers to focus on?

We may need to update the release related scripts on Jenkins before merging this PR.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should generally classify scripts as build, release, lint, start, or test.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated
"build": "npm run bundle && npm run tsc",
"build:debug": "npm run bundle -- -m && npm run tsc",
"build:keys": "node tools/build-keys-from-ts",
"bundle": "rollup -c",
"coverage": "c8 report --reporter lcov && opener coverage/lcov-report/index.html",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, maybe test:open-coverage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like @nzakas to verify before merging. I can update Jenkins script after we merge this.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 0461695 into main Aug 7, 2023
9 checks passed
@nzakas nzakas deleted the update-scripts branch August 7, 2023 15:07
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
@mdjermanovic
Copy link
Member

We may need to update the release related scripts on Jenkins before merging this PR.

Updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants