fix: use eslint-config-airbnb-base by default #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
issue87
branch
3 times, most recently
from
3b787bc
to
b49f7ba
Compare
eslint-congif-airbnb is only used for react. fixes #87
| @@ -133,6 +134,15 @@ export class ConfigGenerator { | |||
| const isESMModule = isPackageTypeModule(this.packageJsonPath); | |||
|
|
|||
| this.result.configFilename = isESMModule ? "eslint.config.js" : "eslint.config.mjs"; | |||
| this.answers.styleguide = typeof this.answers.styleguide === "string" | |||
There was a problem hiding this comment.
In which cases this.answers.styleguide can be a string value?
There was a problem hiding this comment.
More for the future: none of the style guides in the list now support flat configs, so you have to use:
"styleguide": { "packageName": "eslint-config-airbnb", "type": "eslintrc"}But when a certain support is available it can be written as:
"styleguide": "eslint-config-airbnb"
mdjermanovic
approved these changes
Apr 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-congif-airbnb is only used for react.
fixes #87