fix: do not use --force when choosing yarn/eslint v8
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not covered by the snapshot testing; I had tested locally on:
|
1. yarn v2+ does not support it. 2. yarn v1 can install without the flag. fixes #122
aladdin-add
commented
May 31, 2024
| @@ -270,6 +270,17 @@ export default [\n${exportContent}];`; | |||
| choices: ["npm", "yarn", "pnpm", "bun"] | |||
| })).packageManager; | |||
|
|
|||
| // removing `--force` when: | |||
| // 1. yarn v2+ -- it does not support it. | |||
There was a problem hiding this comment.
We don't know if the user is using yarn v1 or yarn v2+, but I've tested yarn v1 is also working fine without --force.
1 task
mdjermanovic
reviewed
Jun 1, 2024
There was a problem hiding this comment.
The flow looks weird now. it asks to install dependencies before listing them.
$ npx @eslint/create-config
√ How would you like to use ESLint? · problems
√ What type of modules does your project use? · esm
√ Which framework does your project use? · react
√ The React plugin doesn't officially support ESLint v9 yet. What would you like to do? · 8.x
√ Does your project use TypeScript? · typescript
√ Where does your code run? · No items were selected
√ Would you like to install them now? · No / Yes
√ Which package manager do you want to use? · npm
The config that you've selected requires the following dependencies:
[email protected], @eslint/js, typescript-eslint, eslint-plugin-react
☕️Installing...
This comment was marked as outdated.
This comment was marked as outdated.
aladdin-add
changed the title
--force when choosing yarn--force when choosing yarn/eslint v8
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122