Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reduce list of releasable tags to feat, fix and perf #115

Merged
merged 1 commit into from
May 17, 2024

Conversation

mdjermanovic
Copy link
Member

Per eslint/eslint#18455, only commits tagged as feat, fix, or perf should trigger a release.

This PR removes all other tags from changelog-types in the release-please configuration.

This means that release-please will no longer consider commits tagged as docs, build, chore, ci, refactor, or test as "releasable units" and will thus no longer create a release PR for those commits. Note that this also means that those commits won't be included in the changelog.

If we merge this before #112, I believe it will remove "switch to eslint v9, eslint-config-eslint v10" from the changelog there, which is okay.

@mdjermanovic
Copy link
Member Author

Some tests unrelated to these changes are failing on the latest Node 22 (v22.2.0). The Node 22 test was passing on the main branch, but that was with v22.1.0. I'll run CI tests again on the main branch to run on Node v22.2.0 and open an issue.

@fasttime
Copy link
Member

If we merge this before #112, I believe it will remove "switch to eslint v9, eslint-config-eslint v10" from the changelog there, which is okay.

Sounds good 👍🏻

@mdjermanovic
Copy link
Member Author

I closed-reopened to rerun CI, and it's passing now.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fasttime fasttime merged commit 66b86fe into main May 17, 2024
16 of 19 checks passed
@fasttime fasttime deleted the release-please-tags branch May 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants