Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove style guides #108

Merged
merged 7 commits into from
Apr 28, 2024
Merged

feat: remove style guides #108

merged 7 commits into from
Apr 28, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 24, 2024 •
edited
Loading

fixes #101 , fixes #95

@aladdin-add aladdin-add marked this pull request as ready for review April 25, 2024 02:12
@aladdin-add aladdin-add requested a review from a team April 25, 2024 02:13
mdjermanovic
mdjermanovic approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Leaving it open for at least one more review from a team member (since this is marked as a feat), and it also needs to wait 2 days before merging.

nzakas
nzakas approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just waiting a couple days.

@mdjermanovic mdjermanovic merged commit de1d085 into main Apr 28, 2024
10 checks passed
@mdjermanovic mdjermanovic deleted the issue101-b branch April 28, 2024 09:34
@github-actions github-actions bot mentioned this pull request Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
accepted feature
Projects
Triage
Archived in project
Milestone
No milestone
3 participants
@aladdin-add @nzakas @mdjermanovic