Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move toggleRuleView to page rules #75

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Jul 9, 2024

When users are not in page rules and clicking the toggleRuleView button, nothing woud happen.

It's strange.

So this PR moves the toggleRuleView button to page rules.

This is how it looks like now:

Screenshot 2024-07-09 at 22 07 08

Besides, a little style change made to rules filter.

Before:

Screenshot 2024-07-09 at 22 08 57

After:

Screenshot 2024-07-09 at 22 09 16

@antfu antfu changed the title refactor: move toggleRuleView to page rules fix: move toggleRuleView to page rules Jul 17, 2024
@antfu antfu merged commit 0fd797c into eslint:main Jul 17, 2024
7 checks passed
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jul 17, 2024
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants