-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add resizeable panels #68
Conversation
Hi @amareshsm!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'm not sure we need this. As soon as you add resizable panels, you also need a way to reset to the default. I'm not sure it's worth the effort. |
Hi @amareshsm!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
It’s similar to the behavior in the playground, where the view resets when the page is reloaded. I think this would be particularly useful on smaller laptops, especially when focusing on either the code on the left or the preview on the right. This feature would allow us to expand the view as needed, providing more flexibility. I'm open to other suggestions as well. If it seems unnecessary, we can close this. |
It looks like the resizing resets when the page is reloaded? If that's intended, then I'm okay with it. |
ya, it resets when reloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Prerequisites checklist
What is the purpose of this pull request?
Added resizable split-view to the resize editor and preview panel.
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?