Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resizeable panels #68

Merged
merged 8 commits into from
Dec 13, 2024
Merged

feat: Add resizeable panels #68

merged 8 commits into from
Dec 13, 2024

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Added resizable split-view to the resize editor and preview panel.

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot
Copy link

Hi @amareshsm!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 9d04317
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/675c4ded6336bc000806227c
😎 Deploy Preview https://deploy-preview-68--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member

nzakas commented Oct 16, 2024

I'm not sure we need this. As soon as you add resizable panels, you also need a way to reset to the default. I'm not sure it's worth the effort.

@eslint-github-bot
Copy link

Hi @amareshsm!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@amareshsm amareshsm changed the title Add resizeable panels feat: Add resizeable panels Dec 13, 2024
@amareshsm amareshsm marked this pull request as ready for review December 13, 2024 15:08
@amareshsm
Copy link
Member Author

amareshsm commented Dec 13, 2024

I'm not sure we need this. As soon as you add resizable panels, you also need a way to reset to the default. I'm not sure it's worth the effort.

It’s similar to the behavior in the playground, where the view resets when the page is reloaded. I think this would be particularly useful on smaller laptops, especially when focusing on either the code on the left or the preview on the right. This feature would allow us to expand the view as needed, providing more flexibility.

I'm open to other suggestions as well. If it seems unnecessary, we can close this.

@nzakas
Copy link
Member

nzakas commented Dec 13, 2024

It looks like the resizing resets when the page is reloaded? If that's intended, then I'm okay with it.

@amareshsm
Copy link
Member Author

It looks like the resizing resets when the page is reloaded? If that's intended, then I'm okay with it.

ya, it resets when reloaded.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit efd344c into main Dec 13, 2024
7 checks passed
@nzakas nzakas deleted the add-resizeable-panels branch December 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants