fix: permit appropriate computed member expressions and prototype access #535
+67
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 649 735 +86
Branches 250 290 +40
=========================================
+ Hits 649 735 +86 ☔ View full report in Codecov by Sentry. |
zloirock
reviewed
Aug 7, 2024
brettz9
force-pushed
the
static-access
branch
2 times, most recently
from
380e467
to
65a8b7d
Compare
scagood
reviewed
Oct 16, 2024
brettz9
force-pushed
the
static-access
branch
from
b64feb1
to
8f2c123
Compare
brettz9
force-pushed
the
static-access
branch
from
8f2c123
to
fd72cbc
Compare
ota-meshi
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Permits appropriate computed member expressions such as
Promise['all']and suitable prototype access (e.g.,Promise.prototype.catch) but errs on detectable problems (e.g.,Promise.prototype.done).Fixes #533, Fixes #534.