feat: add type validation / generate typescript declaration file #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voxpelli
changed the title
voxpelli
force-pushed
the
voxpelli/issue488
branch
from
d9b9cc4
to
c2e7e6d
Compare
|
I've made my own attempt so far at main...brettz9:ts . I'm not partial to using my version or anything, but would you mind providing some general feedback on the general approach (which in my case at least seems to require quite a few type checks)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix #488
What changes did you make? (Give an overview)
tsconfig.jsonas well as a type compilingdeclaration.tsconfig.jsoneslint-plugin-jsdocand improved the JSDoc comments to be compliant with that