add seg to Observation, read it in medsreaders#235
Open
Conversation
Owner
Author
|
Is this an issue with the version of metadetect? |
Collaborator
|
Yeah just add det bands to that list. |
cseg is the coadd seg composited onto the single epoch frame
Owner
Author
|
cseg isn't that useful, I forgot it sets the default value to the id of the object rather than zero |
This one just interpolates coadd seg
Collaborator
|
So uberseg in the meds readers always uses the coadd seg map. It looks like this class will default to use the seg on the obs which in principle will be different. Do we care about this? |
Owner
Author
|
The default is seg in the single epoch image |
Owner
Author
|
Are you proposing that the default change if uberseg is used for weight type? |
Collaborator
|
That's one way to make things less confusing possibly. I think all of the weight types that rely on a seg map use the coadd one so we might want to do this generally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #233