Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dockerfile): add tini for init handling #46

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat(Dockerfile): add tini for init handling #46

merged 1 commit into from
Sep 3, 2024

Conversation

solareon
Copy link
Contributor

@solareon solareon commented Sep 3, 2024

Adds tini to support passing through application signals allowing server to stop without waiting for timeout.

@Micke90s
Copy link
Contributor

Micke90s commented Sep 3, 2024

Yes, the stop signal is not handled correctly now.

In launch.sh the trap kill_corekeeperserver EXIT should run when the container receives the stop signal. Unfortunately, the trap is not called when the container is stopped via docker stop or docker compose down.

This is still an open problem as part of issue #22
I had no time yet to further investigate this problem.

@solareon
Copy link
Contributor Author

solareon commented Sep 3, 2024

So adding tini to the container/entrypoint fixes all of that. This PR adds that. When you stop the container the container stops instantly as the sigterm is passed to the forked process at

DISPLAY=:99 LD_LIBRARY_PATH="$LD_LIBRARY_PATH:../Steamworks SDK Redist/linux64/" ./CoreKeeperServer "${params[@]}"&
.

@arguser arguser self-requested a review September 3, 2024 18:28
@arguser arguser merged commit 5d6416e into escapingnetwork:main Sep 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants