Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize CMake Fetching & Update Mamba CI/ CD #44

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Modernize CMake Fetching & Update Mamba CI/ CD #44

merged 4 commits into from
Oct 16, 2024

Conversation

schuhmaj
Copy link
Collaborator

@schuhmaj schuhmaj commented Oct 15, 2024 •
edited
Loading

Changelog

  • Update CMake Dependency Files
  • Add CMake Target for formatting files according to .clang-format and mention it in CONTRIBUTING.md
  • Update deprecated Mamba Setup in GitHub Actions CI/ CD
  • Remove the USE_LOCAL_TBB option --> Now, this is properly solved by a proper find_package call (redirecting to FetchContent if not found)
  • Fix issues with yaml-cpp not being properly linked when already pre-installed on the system

@schuhmaj schuhmaj self-assigned this Oct 15, 2024
@schuhmaj
update mircomamba CI action
5dec5ef 
- fix the Python Version to 3.12
- add setuptools dependency
- update the deprecated workflow
@schuhmaj
remove the USE_LOCAL_TBB option, rely on CMake; fix issues with yam…
55b1b06 
…l-cpp linking (when not fetched)
@schuhmaj
mention clang-format in CONTRIBUTING.md
f6088c2
@schuhmaj schuhmaj marked this pull request as ready for review October 15, 2024 15:01
@schuhmaj schuhmaj requested a review from gomezzz October 15, 2024 15:01
gomezzz
gomezzz approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but you will know best if / how to address them I think :)

CONTRIBUTING.md Show resolved Hide resolved
cmake/spdlog.cmake Show resolved Hide resolved
environment.yml Show resolved Hide resolved
@schuhmaj
Copy link
Collaborator Author

@gomezzz Thank you for the quick review. I'll keep the clang-format thing in my head (or an issue). Otherwise, free for merge ✅

@schuhmaj schuhmaj merged commit 24b1b5f into main Oct 16, 2024
6 checks passed
@schuhmaj schuhmaj deleted the ci-fix-cmake-update branch October 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees

@schuhmaj schuhmaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuhmaj @gomezzz