Fixes for Dialyzer #338
Merged
Fixes for Dialyzer #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bummer: I'ma fix CI so it only runs Dialyzer on a specific OTP version. |
paulo-ferraz-oliveira
force-pushed
the
fix/for-dialyzer
branch
from
0b373b8 to
47c2f3a
Compare
paulo-ferraz-oliveira
force-pushed
the
fix/for-dialyzer
branch
5 times, most recently
from
ba64db8 to
9653b30
Compare
Whatever hex_tarball:create_docs(Files) returns
create_docs_tarball also returns
:-)
As per hex_core
Takes care of a Dialyzer issue
atoms, not binaries
This reverts commit 97471c2.
paulo-ferraz-oliveira
force-pushed
the
fix/for-dialyzer
branch
from
9653b30 to
4f9b859
Compare
|
CI's failing while we wait for an |
|
@starbelly, this is good to go. No more |
starbelly
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I start by removing all
-dialyzerdirectives and then issuing fixes for the found issues.I'll add self-review comments where appropriate, to ease review.