Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Xcode 11.2 #364

Merged
merged 8 commits into from
Nov 11, 2019
Merged

Update to Xcode 11.2 #364

merged 8 commits into from
Nov 11, 2019

Conversation

madsolar8582
Copy link
Contributor

@madsolar8582 madsolar8582 commented Nov 4, 2018

Description of Changes

Update CI image to Xcode 11 and apply recommended settings.

Motivation and Context

Migrating to latest Xcode to ensure compatibility and apply recommended settings to leverage best practices and leverage new quality checks.

How Has This Been Tested?

Local and CI successful builds.

@erikdoe
Copy link
Owner

erikdoe commented Nov 4, 2018

It looks like the build on TravisCI is failing. I only had a cursory look at the output and couldn't immediately see what's wrong, but this needs fixing.

I'm also not sure about mixing a number of different concerns in this single PR, but I will comment on them individually.

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@madsolar8582
Copy link
Contributor Author

Looks like the Travis build failed for this particular run due to an issue in Apple's simulator control. My build of the same commit succeeded: https://travis-ci.com/madsolar8582/ocmock/builds/90191297

@erikdoe
Copy link
Owner

erikdoe commented Nov 4, 2018

Good news, I re-ran the build manually and it passed now.

@madsolar8582
Copy link
Contributor Author

Thanks Erik. I merged your current changes onto this branch.

@madsolar8582 madsolar8582 changed the title Update to Xcode 10.1 Update to Xcode 10.2 Jul 23, 2019
@madsolar8582 madsolar8582 changed the title Update to Xcode 10.2 Update to Xcode 11 Aug 5, 2019
@erikdoe
Copy link
Owner

erikdoe commented Aug 22, 2019

To be honest, I'd feel better to wait until Xcode 11 has left beta and is generally available.

For future PRs: it was slightly confusing to see a PR with the title "Update to Xcode 11" and a date of November 2018. For a moment I thought I had missed something. Would be good open a new PR instead of repurposing an old one.

@madsolar8582 madsolar8582 changed the title Update to Xcode 11 Update to Xcode 11.2 Oct 11, 2019
@erikdoe
Copy link
Owner

erikdoe commented Oct 20, 2019

Thank you for submitting these PR's. It seems you're always a step ahead of what's available through normal channels. I will now update to Xcode 11.1, which is, according to the AppStore, the current version.

@erikdoe erikdoe merged commit f1873ab into erikdoe:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants