Update Empty requests list behaviour for Pectra-5 #12985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
added
pectra
somnathb1
changed the title
|
This is 4/6 in the chain |
somnathb1
removed
the
do-not-merge
somnathb1
force-pushed
the
som/fixReq_Addr
branch
from
ae7113e to
020b06c
Compare
somnathb1
force-pushed
the
som/eip7685
branch
from
6056a08 to
aa0622e
Compare
yperbasis
reviewed
Jan 13, 2025
yperbasis
reviewed
Jan 13, 2025
yperbasis
reviewed
Jan 13, 2025
yperbasis
reviewed
Jan 13, 2025
yperbasis
reviewed
Jan 13, 2025
yperbasis
reviewed
Jan 13, 2025
yperbasis
reviewed
Jan 13, 2025
turbo/engineapi/engine_server.go
Outdated
| } | ||
| requests[i] = types.FlatRequest{Type: r, RequestData: executionRequests[i]} | ||
| requests = make(types.FlatRequests, 0) | ||
| for _, r := range executionRequests { |
There was a problem hiding this comment.
Please guard against the case when r is empty
There was a problem hiding this comment.
Is this bit of the spec implemented: "Elements of the list MUST be ordered by request_type in ascending order. Elements with empty request_data MUST be excluded from the list. If any element is out of order or has a length of 1-byte or shorter, client software MUST return -32602: Invalid params error."?
There was a problem hiding this comment.
No, here it doesn't throw the error. This was beneficial to run some early implementations of CLs, but I have made the change now to address the concern.
yperbasis
approved these changes
Jan 14, 2025
somnathb1
added a commit
that referenced
this pull request
Jan 15, 2025
The updated EIP-7685 says requests with empty `request_data` should be dropped from `executionRequests` field in the API and ignored for hash calculation. See ethereum/EIPs#8989, ethereum/execution-apis#599 Issue board: #12401
somnathb1
added a commit
that referenced
this pull request
Jan 15, 2025
The updated EIP-7685 says requests with empty `request_data` should be dropped from `executionRequests` field in the API and ignored for hash calculation. See ethereum/EIPs#8989, ethereum/execution-apis#599 Issue board: #12401 Cherry pick #12985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated EIP-7685 says requests with empty
request_datashould be dropped fromexecutionRequestsfield in the API and ignored for hash calculation.See ethereum/EIPs#8989, ethereum/execution-apis#599
Issue board: #12401