Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7 via sketch module. #19

Merged
merged 7 commits into from
May 26, 2018
Merged

Fixes #7 via sketch module. #19

merged 7 commits into from
May 26, 2018

Commits on May 18, 2018

  1. WIP: working on sketch module\nWorking on writing a seperate sketch m…

    …odule that incorporates additional sketching aglorithms
    jknox13 committed May 18, 2018
    Configuration menu
    Copy the full SHA
    377e997 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77c8cef View commit details
    Browse the repository at this point in the history

Commits on May 21, 2018

  1. WIP: Tests passing for sketch module.

    Work in progress. ``sketch`` module is implemented, but old
    compatibility funcitons in ``sketch.range_finders`` still need to be
    phased out.
    jknox13 committed May 21, 2018
    Configuration menu
    Copy the full SHA
    1838bb8 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. WIP: Finished phasing out old sketch module.

    Still need to better incorporate within random methods, perhaps giving
    transform options. Also still need to standardize parameter names.
    
    Additionally, single_pass methods have been depricated (masked with a
    single subspace iteration) for now because the previous implementation
    was not in fact 'single_pass'.
    jknox13 committed May 23, 2018
    Configuration menu
    Copy the full SHA
    89b7030 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b4815a View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Tests now align with PEP parameter changes.

    For the most part package now conforms with PEP parameter name
    guidelines.
    
    Still to do:
    - `pca` : factor pca/spca/robspca
    - `nmf` : factor and PEP parameter name eval
    - `sketch` : ensure row wise sketches are indeed row wise and write
    numerical accuracy checking tests
    
    Additionally, in general there can be a lot of improvement as far as
    code reproduction reduction in the testing modules.
    jknox13 committed May 24, 2018
    Configuration menu
    Copy the full SHA
    e4deccd View commit details
    Browse the repository at this point in the history
  2. Move calling of subspace iterations.

    The calling of `perform_subspace_iterations` now resides outside of the
    transform functions so that it can be used independent of which
    transform is used.
    
    Additionally, default n_subspace has been set to 2.
    jknox13 committed May 24, 2018
    Configuration menu
    Copy the full SHA
    c685abd View commit details
    Browse the repository at this point in the history