Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Contract template compiler #937

Merged
merged 14 commits into from
Dec 13, 2023
Merged

[WIP] Contract template compiler #937

merged 14 commits into from
Dec 13, 2023

Conversation

ross-weir
Copy link
Contributor

@ross-weir ross-weir commented Nov 18, 2023 •
edited
Loading

closes #852

  • lots of polishing
  • harden some parsers to account for whitespace & new lines
  • replace with SigmaParser parsers where possible
  • tests/docs

@ross-weir
Copy link
Contributor Author

ross-weir commented Nov 27, 2023 •
edited
Loading

@aslesarenko i have a few todos left but this could have an initial quick looking over - contract template compilation is working

@aslesarenko aslesarenko marked this pull request as ready for review November 28, 2023 12:27
@aslesarenko aslesarenko self-requested a review November 28, 2023 12:27
aslesarenko
aslesarenko requested changes Nov 28, 2023
View reviewed changes
parsers/shared/src/main/scala/sigmastate/lang/ContractDocParser.scala Outdated Show resolved Hide resolved
parsers/shared/src/main/scala/sigmastate/lang/ContractDocParser.scala Outdated Show resolved Hide resolved
parsers/shared/src/main/scala/sigmastate/lang/ContractTemplateParser.scala Outdated Show resolved Hide resolved
parsers/shared/src/main/scala/sigmastate/lang/ContractDocParser.scala Outdated Show resolved Hide resolved
parsers/shared/src/main/scala/sigmastate/lang/ContractDocParser.scala Outdated Show resolved Hide resolved
parsers/shared/src/main/scala/sigmastate/lang/ContractSignatureParser.scala Outdated Show resolved Hide resolved
sc/shared/src/main/scala/sigmastate/lang/SigmaTemplateCompiler.scala Outdated Show resolved Hide resolved
@ross-weir ross-weir requested a review from aslesarenko December 1, 2023 09:34
aslesarenko
aslesarenko requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@aslesarenko aslesarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, otherwise looks good.

parsers/shared/src/main/scala/sigmastate/lang/ContractParser.scala Outdated Show resolved Hide resolved
@aslesarenko
Copy link
Member

Also, please fix the tests.

@ross-weir
Copy link
Contributor Author

Also, please fix the tests.

I'm guessing it might have been due to trailing comma which is now removed, I wasn't able to recreate the error locally

@aslesarenko aslesarenko changed the base branch from develop to v5.0.14-RC December 13, 2023 22:53
@aslesarenko aslesarenko merged commit 2097bc1 into ergoplatform:v5.0.14-RC Dec 13, 2023
3 of 4 checks passed
@aslesarenko aslesarenko mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslesarenko aslesarenko aslesarenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ContractTemplate compiler
2 participants
@ross-weir @aslesarenko