[6.0] Revise liftToConstant method #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
approved these changes
Dec 4, 2024
| case n: sigma.BigInt => Nullable(mkConstant[SBigInt.type](n, SBigInt)) | ||
| case n: sigma.UnsignedBigInt => Nullable(mkConstant[SUnsignedBigInt.type](n, SUnsignedBigInt)) | ||
| case ge: GroupElement => Nullable(mkConstant[SGroupElement.type](ge, SGroupElement)) | ||
| case b: Boolean => Nullable(if (b) TrueLeaf else FalseLeaf) | ||
| case v: String => Nullable(mkConstant[SString.type](v, SString)) | ||
| case v: String if !VersionContext.current.isV6SoftForkActivated => Nullable(mkConstant[SString.type](v, SString)) | ||
| case h: Header if VersionContext.current.isV6SoftForkActivated => Nullable(mkConstant[SHeader.type](h, SHeader)) |
There was a problem hiding this comment.
PreHeader is also supported type, they usually come together everywhere.
| case n: sigma.BigInt => Nullable(mkConstant[SBigInt.type](n, SBigInt)) | ||
| case ge: GroupElement => Nullable(mkConstant[SGroupElement.type](ge, SGroupElement)) | ||
| case b: Boolean => Nullable(if (b) TrueLeaf else FalseLeaf) | ||
| case v: String => Nullable(mkConstant[SString.type](v, SString)) | ||
| case h: Header if VersionContext.current.isV6SoftForkActivated => Nullable(mkConstant[SHeader.type](h, SHeader)) |
| @@ -122,6 +122,13 @@ class SigmaBuilderTest extends AnyPropSpec with ScalaCheckPropertyChecks with Ma | |||
| testSuccess(arr, TransformingSigmaBuilder.mkCollectionConstant(arr, c.tpe)) | |||
| } | |||
|
|
|||
| def testArrayFailure[T <: SType] | |||
| (v: T#WrappedType, c: Constant[T])(implicit t: RType[T#WrappedType]) = { | |||
| // for any Byte and Short value `v`, lifting of array should succeed | |||
There was a problem hiding this comment.
Isn't is generic enough to work for any type? Comment somewhat misleading.
interpreter/shared/src/test/scala/sigma/ast/SigmaBuilderTest.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: Alexander Slesarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #905