close #1044 : fix for Global.decodeNBits method can produce bigint ou…

…t of 256 bits scope
ergoplatform · Jan 6, 2025 · aa61236 · aa61236
1 parent d13dd4d
commit aa61236
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/data/shared/src/main/scala/sigma/data/CSigmaDslBuilder.scala b/data/shared/src/main/scala/sigma/data/CSigmaDslBuilder.scala
@@ -192,7 +192,8 @@ class CSigmaDslBuilder extends SigmaDslBuilder { dsl =>
   }
 
   override def decodeNbits(l: Long): BigInt = {
-    CBigInt(NBitsUtils.decodeCompactBits(l).bigInteger)
+    // Result is limited to 256 bits with .toSignedBigIntValueExact
+    CBigInt(NBitsUtils.decodeCompactBits(l).bigInteger.toSignedBigIntValueExact)
   }
 
   /**

diff --git a/sc/shared/src/test/scala/sigmastate/utxo/BasicOpsSpecification.scala b/sc/shared/src/test/scala/sigmastate/utxo/BasicOpsSpecification.scala
@@ -3200,4 +3200,23 @@ class BasicOpsSpecification extends CompilerTestingCommons
     }
   }
 
+  property("Global.decodeNbits - result of more than 256 bits") {
+    def someTest(): Assertion = {
+      test("some", env, ext,
+        s"""{
+          |   val target = Global.decodeNbits(${Long.MaxValue}L) // result is 2031 bits long
+          |   target != 0
+          |}""".stripMargin,
+        null
+      )
+    }
+
+    if (VersionContext.current.isV6SoftForkActivated) {
+      // on JVM, InvocationTargetException wrapping (ArithmeticException: BigInteger out of 256 bit range) is thrown
+      an[Exception] should be thrownBy someTest()
+    } else {
+      an[sigma.validation.ValidationException] should be thrownBy someTest()
+    }
+  }
+
 }