i1784 remove invalid tx from mempool and delivery tracker #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyFailedModification and invalidated in DeliveryTracker
…e' of github.com:ergoplatform/ergo into i1784-remove-invalid-tx-from-mempool-and-delivery-tracker
…er' of github.com:ergoplatform/ergo into i1784-remove-invalid-tx-from-mempool-and-delivery-tracker
…e' of github.com:ergoplatform/ergo into i1784-remove-invalid-tx-from-mempool-and-delivery-tracker
…er' of github.com:ergoplatform/ergo into i1784-remove-invalid-tx-from-mempool-and-delivery-tracker
Base automatically changed from
i1801-modifier-error-should-contain-modifier-id-and-type
to
v4.0.40
August 17, 2022 17:21
…ove-invalid-tx-from-mempool-and-delivery-tracker
kushti
reviewed
Aug 22, 2022
| history.reportModifierIsInvalid(modToApply, progressInfo).map { case (newHis, newProgressInfo) => | ||
| context.system.eventStream.publish(SemanticallyFailedModification(modToApply, e)) | ||
| UpdateInformation(newHis, updateInfo.state, Some(modToApply), Some(newProgressInfo), updateInfo.suffix) | ||
| case Failure(ex: MalformedModifierError) if ex.modifierTypeId == Transaction.ModifierTypeId => |
There was a problem hiding this comment.
how can transaction appear here at all?
Failed modifier should be a block I guess
There was a problem hiding this comment.
It works like this :
- in either way :
modToApplyis reported as invalid - if
MalformedModifierErrorwithTxTypeis catched, we managed to find the invalid TX here https://github.com/ergoplatform/ergo/pull/1803/files#diff-85a518f9e45c7c4c4119bd8b54f22b95446a2c2c24b5b8328e1c6c4b7bbca4bdR93-R101 - otherwise we just report invalid
modToApply
I assume that even though block is considered invalid, we wanted to flag invalidate this particular TX in mempool, right?
There was a problem hiding this comment.
Not so simple, as history.reportModifierIsInvalid is expecting block ,not transaction
There was a problem hiding this comment.
We call reportModifierIsInvalid(modToApply) in both cases, just in case of MalformedModifierError with TxType modifier we EliminateTransactions so it gets removed from MemPool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1784