Open
Conversation
gnuille
commented
Nov 26, 2024
gnuille
commented
- Add edge tooltip
- Remove markupsafe transitive dependency
- Change logging handler to local logger
erdogant
approved these changes
Jul 11, 2025
erdogant
approved these changes
Jul 11, 2025
erdogant
approved these changes
Jul 11, 2025
erdogant
approved these changes
Jul 11, 2025
All handlers are removed from the root logger and replace by a handler which logs with "[d3graph]" prefix. This causes that this prefix appears in logs from other modules. It also interferes with pytest log handles. This PR performs the handler replacement only for the local logger.
gnuille
force-pushed
the
edge-tooltip-prop-mr
branch
from
7589aca to
956f559
Compare
Author
|
Sorry for being so late to rebase, everything ready now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.