Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Analytic Geometry using PUMI #1217

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

zhang-alvin
Copy link
Contributor

Mandatory Checklist

Please ensure that the following criteria are met:

  • Title of pull request describes the changes/features
  • Request at least 2 reviewers
  • If new files are being added, the files are no larger than 100kB. Post the file sizes.
  • Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
  • New features have appropriate documentation strings (readable by sphinx)
  • Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.

Description

Add the capability of circle in rectangle using parameterization API available through scorec/core (PUMI). A parameterization allows for mesh adaptation to snap onto the geometry properly, thereby enabling proper meshing for moving objects.

  • Generalize functions to work with 2D and 3D interchangeably
  • Need to add a test

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1217   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files         526      526           
  Lines      108803   108803           
=======================================
  Hits        56684    56684           
  Misses      52119    52119           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f338ae4...6f76661. Read the comment docs.

Base automatically changed from master to main February 10, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant