Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SYSTEM EXCLUDE_FROM_ALL for add_subdirectory of third party #3475

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Sep 19, 2024

So basically

  • treat 3rd party header as system header (so no warnings from their header)
  • Avoid to install 3rd party from their CMakeFile.txt, in particular llama.cpp's include/lib/cmake are non longer in msys installer)
    (didn't succeed to do it properly for wxsqlite3 because of UT requiring .so file)

@eranif eranif merged commit 3b9aabf into eranif:master Sep 23, 2024
4 checks passed
@Jarod42 Jarod42 deleted the add_subdirectory_system branch September 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants