PHPParser: Handle PHP Attributes #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds very basic parsing of PHP Attributes. Nothing about the content of the attribute is understood or retained, this is just enough to not encounter a parser errors for files that contain non-backwards compatible attributes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3388
This adds very basic parsing of PHP Attributes. Nothing about the content of the attribute is understood or retained, this is just enough to not encounter a parser errors for files that contain non-backwards compatible attributes.
In the long run we will probably need something like PHPDocComment.cpp for parsing the content. Though I'm not sure if that is the right way to go since the format is a lot more formal then PHPDoc.