Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add github action for macos #3337

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[CI] Add github action for macos #3337

merged 1 commit into from
Mar 20, 2024

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Mar 19, 2024

cmake --build . --target install

- name: codelite --version
run: codelite --version || exit 0 # codelite --version returns -1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? it should be:

codelite.app/Contents/MacOS/codelite --version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Users/runner/work/_temp/02ffa54b-035d-4b75-bef9-f8728bd7b170.sh: line 1: codelite: command not found

Indeed, not.
Changed with your version, waiting for CI.

@eranif eranif merged commit 932064f into eranif:master Mar 20, 2024
2 checks passed
@Jarod42 Jarod42 deleted the CI_macos branch March 20, 2024 16:29
@Jarod42
Copy link
Contributor Author

Jarod42 commented Mar 20, 2024

codelite.app/Contents/MacOS/codelite: No such file or directory

That version doesn't work neither

Whole block can be removed (As important think, the build, passes).
Or macos users might check correct command (I don't know if it is path issue, or something similar).

Comment on lines +31 to +32
../configure --enable-shared --enable-monolithic --with-osx_cocoa CXX='clang++ -std=c++11 -stdlib=libc++ -I../src/tiff/libtiff' CC=clang --disable-debug --disable-mediactrl --enable-stl
make -j10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode it to 10 jobs?

Also, CodeLite is now built using C++17, no? Is there any reason why wxWidgets is built using an older standard on macOS (I've never owned a Mac)?

Copy link
Owner

@eranif eranif Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarod42 we could probably use

 make -j$(sysctl -n hw.ncpu) install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly copy-paste code from https://docs.codelite.org/build/build_wx_widgets/#macos

I don't have MacOS neither.

Created #3339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants