-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add github action for macos #3337
Conversation
.github/workflows/macos.yml
Outdated
cmake --build . --target install | ||
|
||
- name: codelite --version | ||
run: codelite --version || exit 0 # codelite --version returns -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? it should be:
codelite.app/Contents/MacOS/codelite --version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Users/runner/work/_temp/02ffa54b-035d-4b75-bef9-f8728bd7b170.sh: line 1: codelite: command not found
Indeed, not.
Changed with your version, waiting for CI.
That version doesn't work neither Whole block can be removed (As important think, the build, passes). |
../configure --enable-shared --enable-monolithic --with-osx_cocoa CXX='clang++ -std=c++11 -stdlib=libc++ -I../src/tiff/libtiff' CC=clang --disable-debug --disable-mediactrl --enable-stl | ||
make -j10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why hardcode it to 10 jobs?
Also, CodeLite is now built using C++17, no? Is there any reason why wxWidgets is built using an older standard on macOS (I've never owned a Mac)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jarod42 we could probably use
make -j$(sysctl -n hw.ncpu) install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly copy-paste code from https://docs.codelite.org/build/build_wx_widgets/#macos
I don't have MacOS neither.
Created #3339.
52m job https://github.com/Jarod42/codelite/actions/runs/8343196567
spot the issue about SideBarToolBar :) https://github.com/Jarod42/codelite/actions/runs/8339588463/job/22821858878
[edited]: only 25min here :-)