Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin scikit-build-core with some maintenance commits #970

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Nov 8, 2023

Groups a few tiny maintenance issues into their atomic commits

Resolves #928
Resolves #960
Resolves #964
Resolves #969

Version 0.6.1 was released which fixes the editable installation
regression introduced in 0.6.0.
Use the maintaining team's email and list all operating systems.
This file and the function is contained was not being used.
@mferrera mferrera self-assigned this Nov 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #970 (de0917c) into main (b0aa977) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   80.48%   80.46%   -0.02%     
==========================================
  Files          91       91              
  Lines       13512    13509       -3     
  Branches     2227     2227              
==========================================
- Hits        10875    10870       -5     
- Misses       1910     1911       +1     
- Partials      727      728       +1     
Files Coverage Δ
src/xtgeo/grid3d/_find_gridprop_in_eclrun.py 94.00% <100.00%> (-0.03%) ⬇️
src/xtgeo/grid3d/_gridprop_import_eclrun.py 84.09% <100.00%> (-0.36%) ⬇️
src/xtgeo/grid3d/_gridprops_import_eclrun.py 82.35% <100.00%> (-0.15%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mferrera mferrera marked this pull request as ready for review November 8, 2023 12:40
@mferrera mferrera requested a review from jcrivenaes November 8, 2023 12:40
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mferrera mferrera merged commit 49f4c5c into equinor:main Nov 8, 2023
26 checks passed
@mferrera mferrera deleted the maint-updates branch November 8, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants