Add typing to common.sys
#968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
commented
Nov 8, 2023
jcrivenaes
reviewed
Nov 8, 2023
jcrivenaes
reviewed
Nov 8, 2023
jcrivenaes
approved these changes
Nov 8, 2023
mferrera
force-pushed
the
mypy-common-sys
branch
from
5724fbd to
791b0bb
Compare
Also does some minor refactoring, particularly to the initialization function.
mferrera
force-pushed
the
mypy-common-sys
branch
from
791b0bb to
3c3f287
Compare
Codecov Report
@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 80.46% 80.41% -0.06%
==========================================
Files 91 91
Lines 13509 13504 -5
Branches 2227 2227
==========================================
- Hits 10870 10859 -11
- Misses 1911 1918 +7
+ Partials 728 727 -1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also does some minor refactoring, particularly to the initialization function.
Resolves #897