Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the recent Well() refactor gets wrong log_record codes #963

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

jcrivenaes
Copy link
Collaborator

Solves #962

For unknown reasons, pylint reports "missing
members" on eg. xtgeo:GridProperty() - silence
this with this setting.
@jcrivenaes jcrivenaes requested a review from mferrera November 7, 2023 12:09
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just a hanging comment

src/xtgeo/well/_well_oper.py Outdated Show resolved Hide resolved
@jcrivenaes jcrivenaes force-pushed the fix-well-refactor-issues branch from 2f7bb33 to fce8508 Compare November 7, 2023 12:22
@codecov-commenter
Copy link

Codecov Report

Merging #963 (fce8508) into main (3a3507c) will decrease coverage by 0.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   80.47%   80.46%   -0.01%     
==========================================
  Files          91       91              
  Lines       13510    13512       +2     
  Branches     2226     2227       +1     
==========================================
+ Hits        10872    10873       +1     
  Misses       1911     1911              
- Partials      727      728       +1     
Files Coverage Δ
src/xtgeo/xyz/_xyz_data.py 84.26% <ø> (ø)
src/xtgeo/well/_well_oper.py 70.87% <93.75%> (-0.13%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jcrivenaes jcrivenaes merged commit b0aa977 into equinor:main Nov 7, 2023
26 checks passed
@jcrivenaes jcrivenaes deleted the fix-well-refactor-issues branch November 7, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants