CLN: Add typing to roff_grid #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
reviewed
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #949 +/- ##
==========================================
- Coverage 80.58% 80.57% -0.01%
==========================================
Files 91 91
Lines 13481 13488 +7
Branches 2223 2224 +1
==========================================
+ Hits 10863 10868 +5
- Misses 1898 1899 +1
- Partials 720 721 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #895
Me and @ErichSuter worked on this together, we looked at the doc. strings, to the best of our knowledge they look right. But an extra pair of eyes wound not hurt.