Add GridProperty typing and update docstrings #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
mypy-gridproperty
branch
from
5979a79 to
8192b65
Compare
Codecov Report
@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 80.58% 80.53% -0.05%
==========================================
Files 91 91
Lines 13481 13490 +9
Branches 2223 2220 -3
==========================================
+ Hits 10863 10864 +1
- Misses 1898 1904 +6
- Partials 720 722 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mferrera
force-pushed
the
mypy-gridproperty
branch
3 times, most recently
from
6bf2c9d to
a804c2b
Compare
mferrera
changed the title
mferrera
commented
Oct 30, 2023
mferrera
force-pushed
the
mypy-gridproperty
branch
from
a804c2b to
be1c5db
Compare
janbjorge
reviewed
Oct 30, 2023
janbjorge
reviewed
Oct 30, 2023
janbjorge
reviewed
Oct 30, 2023
janbjorge
reviewed
Oct 30, 2023
janbjorge
reviewed
Oct 30, 2023
janbjorge
reviewed
Oct 30, 2023
janbjorge
reviewed
Oct 30, 2023
mferrera
force-pushed
the
mypy-gridproperty
branch
4 times, most recently
from
4b2e440 to
46f9cae
Compare
Explicitly use `sphinx-autodoc-typehints` rather than its extension, as the extension just installs it anyway. Also move autodoc options to default options in `conf.py` and adjust some settings that fix autodoc typehint resolution.
mferrera
force-pushed
the
mypy-gridproperty
branch
from
46f9cae to
5866fef
Compare
Includes some mild refactoring.
mferrera
force-pushed
the
mypy-gridproperty
branch
from
5866fef to
f56b9cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #631
Resolves #889
Makes progress on #940