Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: undef values in grdecl export shall be 0 or 1 #1280

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jcrivenaes
Copy link
Collaborator

@jcrivenaes jcrivenaes commented Dec 5, 2024

Closes #1279

Note: It could also be possible to let the user input this value, but that will be a larger change. I propose we add this a patch now and consider future improvements later.

Related to this is also the use of the isdiscrete property and dtype option in the to_file() appears unclear for me now. Perhaps a need for a deeper look into this at some point.

@jcrivenaes jcrivenaes requested review from mferrera and tnatt December 5, 2024 13:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (0375fed) to head (28f6930).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
+ Coverage   80.02%   81.15%   +1.12%     
==========================================
  Files          98       94       -4     
  Lines       13680    12436    -1244     
  Branches     2203     1874     -329     
==========================================
- Hits        10948    10092     -856     
+ Misses       1999     1685     -314     
+ Partials      733      659      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcrivenaes jcrivenaes merged commit 1af8dbb into equinor:main Dec 5, 2024
39 checks passed
@jcrivenaes jcrivenaes deleted the grdecl-fmt-fix branch December 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbers applied for undefined values in grdecl export of GridProperty should be zero (or one)
3 participants