BLD: Update numpy.i, CI: unlink deprecated pkg-config in macOS #1271
Conversation
SWIG 4.3.0 was released, causing the numpy bindings to need updating else compiling fails.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
+ Coverage 80.02% 81.14% +1.12%
==========================================
Files 98 94 -4
Lines 13680 12435 -1245
Branches 2203 1874 -329
==========================================
- Hits 10948 10091 -857
+ Misses 1999 1685 -314
+ Partials 733 659 -74 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| # pkg-config formula is deprecated but it's still installed | ||
| # in GitHub Actions runner now. We can remove this once | ||
| # pkg-config formula is removed from GitHub Actions runner. | ||
| brew unlink [email protected] |
There was a problem hiding this comment.
brew apparently needs a specific version to unlink from. This version came from here.
mferrera
changed the title
macOS GitHub Action Runners come with pkg-config installed, but this package is deprecated in brew. Replace it with pkgconf. This can be reverted when Action Runners are no longer imaged with pkg-config.
|
I don't get why, but this change is responsible for this failure: https://github.com/equinor/res2df/actions/runs/12049771698/job/33597222979?pr=513 (there solved by pinning "xtgeo < 4.3.2" for py38. |
|
I'll take a look at it. Nobody really understands the swig bindings. This change was simply to copy them from https://github.com/numpy/numpy/blob/main/tools/swig/numpy.i so it's less likely to contain the bug, but maybe numpy has already deprecated some 3.8 compatibility stuff in doing so. |
Resolves #1269
pkg-configwas renamed topkgconfbut macOS GH Runners are imaged with pkg-config.