Bugfix: Floor missing, wrong bounding boxes #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strepto
reviewed
Nov 5, 2024
| if (mesh.Vertices.Length > 0) | ||
| { | ||
| // Recalculating AABB, since some instances of the transformed (p.AxisAlignedBoundingBox) AABB were incorrect | ||
| // Guarded agaings meshes with zero vertices, to avoid throwing an exception |
There was a problem hiding this comment.
Suggested change
| // Guarded agaings meshes with zero vertices, to avoid throwing an exception | |
| // Guarded against meshes with zero vertices, to avoid throwing an exception. Empty meshes are filtered out later. |
Strepto
approved these changes
Nov 5, 2024
|
Add some comments to why we needed to do this. (Show a screenshot of the issue for example) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: AB#188616
Some bounding boxes were wrong, and caused parts of the model to pop in and out. This happened because of some error with rotation in the input rvm data matrixes, and seemed to only happen with a few parts.
Fix: Recalculate bounding boxes based on the mesh. This is quite fast, and does not have a noticable impact on the build times.
Example image of bounds not following part. Calculating the bounds without the Rotation component in the rvm matrix got the correct rotation, but this was more generally wrong. Instead of trusting the input bounds we now use the mesh bounds, as we have not identified issues with the mesh positions (yet...)
