Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of missing responses.json #9589

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jonathan-eq
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #9589 will not alter performance

Comparing jonathan-eq:fix-missing_responses_error (5553bdc) with main (1889e2a)

Summary

✅ 24 untouched benchmarks

…bleselector

This raised an AttributeError which Qt swallowed
@jonathan-eq jonathan-eq force-pushed the fix-missing_responses_error branch from d644aee to 2fe1d74 Compare December 18, 2024 14:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (01156bb) to head (869f845).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
.../ert/gui/tools/manage_experiments/storage_model.py 77.77% 6 Missing ⚠️
src/ert/gui/ertwidgets/ensembleselector.py 66.66% 4 Missing ⚠️
src/ert/storage/local_experiment.py 82.35% 3 Missing ⚠️
src/ert/storage/local_ensemble.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9589      +/-   ##
==========================================
- Coverage   91.85%   91.83%   -0.03%     
==========================================
  Files         433      433              
  Lines       26768    26879     +111     
==========================================
+ Hits        24587    24683      +96     
- Misses       2181     2196      +15     
Flag Coverage Δ
cli-tests 39.69% <22.66%> (-0.07%) ⬇️
everest-models-test 34.55% <18.66%> (-0.04%) ⬇️
gui-tests 72.13% <77.33%> (+0.02%) ⬆️
integration-test 38.71% <22.66%> (+1.51%) ⬆️
performance-tests 51.88% <36.00%> (-0.06%) ⬇️
test 40.02% <22.66%> (-0.43%) ⬇️
unit-tests 74.06% <48.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants