Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make joint option for queue_name #9355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make joint option for queue_name #9355

wants to merge 2 commits into from

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 26, 2024 •
edited
Loading

This converts for example LSF_QUEUE to a generic config option.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the consolidate_queue branch 2 times, most recently from 705f539 to 61a909e Compare November 27, 2024 07:06
berland
berland reviewed Nov 27, 2024
View reviewed changes
src/ert/config/queue_config.py Outdated
or (q_system == QueueSystem.SLURM and options[0] == "PARTITION")
or (q_system == QueueSystem.TORQUE and options[0] == "QUEUE")
):
ConfigWarning.deprecation_warn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this looks untested)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, only indirectly, added a test now 👍

@oyvindeide oyvindeide self-assigned this Nov 28, 2024
@oyvindeide oyvindeide added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@oyvindeide oyvindeide

Labels
release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oyvindeide @berland @eivindjahren