Trigger batching dispatcher on success/failure of ensemble #9183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHolba
added
the
release-notes:improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9183 +/- ##
==========================================
- Coverage 90.74% 90.71% -0.04%
==========================================
Files 352 352
Lines 21937 21939 +2
==========================================
- Hits 19907 19902 -5
- Misses 2030 2037 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
btw, if you want to connect PR with the issue you need to write either Fixes, Resolves and then the issue |
xjules
reviewed
Nov 15, 2024
| @@ -147,6 +147,8 @@ def set_event_handler(event_types: Set[Type[Event]], func: Any) -> None: | |||
| function = event_handler[type(event)] | |||
| batch.append((function, event)) | |||
| self._events.task_done() | |||
| if type(event) in [EnsembleSucceeded, EnsembleFailed]: | |||
There was a problem hiding this comment.
I made the comment in the issue: #9136 (comment)
This if would make batching slower for no relevant reason.
xjules
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#9136
Approach
Send batch from batching dispatcher immediately when we get EnsembleSucceeded or EnsembleFailed.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable