Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding /share-list url to display simple list of active shares #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stiix13
Copy link

@stiix13 stiix13 commented Jan 7, 2022

Add /share-list URL if "list-passwords" param is set. Display a simple list of active shares.

@epoupon
Copy link
Owner

epoupon commented Jan 8, 2022

Hi!
Just tested, thanks for this.
I wonder if it is time to add some user management though.
We could add a login form (with 'remember me' option), accessible from the menu.
An admin user can then log in and have direct access to this new page, still using the menu.
Furthermore, the admin user could create some regular users and grant them the upload privilege (no longer require users to enter a password to upload)

What do you think? (of course I can add this myself, I don't ask you to add this whole stuff :))

@CEbbinghaus
Copy link

Damn this is crazy. Did not expect this project to still be so active. But I 100% agree that some user management would be great.
I think something like guest users would also be useful and allowing for different time/sizes for guests vs users vs admins would give even more granular control over data/usage. I would be very keen for this and to allow for users to see all of the shares they created as well as admin being able to see all shares as well as all shares of any of the users/admins. I think this would make a wonderful addition

@stiix13
Copy link
Author

stiix13 commented Jan 10, 2022

Just a "remember me" option on the login page would be already nice but I guess you need to implement some part of user management for this to work, so yes that could be very handy. At least I would say, as @CEbbinghaus already said, being able as a user to see all my active shares and as admin see all shares, even if the configuration need to be done in the conf file at first.

I'm glad you don't ask as I haven't done a lot of C++ in a long time ; ) but if you need some kind of help feel free to ask.

@epoupon
Copy link
Owner

epoupon commented Jan 10, 2022

Lot of promising stuff here, let's do this for a v6 then!

@epoupon epoupon mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants