Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 098 - Hide Create New button on Download page #101

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

andymarden
Copy link
Contributor

Ok - done!

Addresses issue #98 and is directly off the develop branch

This removes the icon link top left completely since it is troublesome and adds no perceived value and is a pain to deal with. I can update and find a solution if necessary.

@epoupon
Copy link
Owner

epoupon commented Feb 2, 2024

Thanks!
Can you please update the PR to merge into the develop branch instead of master? It is quite hard to see your changes

@andymarden andymarden changed the base branch from master to develop February 3, 2024 07:37
@andymarden
Copy link
Contributor Author

My mistake - that's done I think.

Copy link
Owner

@epoupon epoupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few simplifications :)

src/fileshelter/ui/FileShelterApplication.hpp Outdated Show resolved Hide resolved
src/fileshelter/ui/FileShelterApplication.hpp Outdated Show resolved Hide resolved
src/fileshelter/ui/FileShelterApplication.hpp Outdated Show resolved Hide resolved
@andymarden
Copy link
Contributor Author

Cheers - will look at that and update accordingly

@andymarden andymarden changed the title Andy issue 098 Issue 098 - Hide Create New button on Download page Feb 4, 2024
@andymarden
Copy link
Contributor Author

OK - changes made and seems to work fine in this simpler manner

Copy link
Owner

@epoupon epoupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good news!
We are almost done I think :)

src/fileshelter/ui/FileShelterApplication.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/FileShelterApplication.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/FileShelterApplication.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/ShareCreate.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/ShareCreated.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/ShareDownload.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/ShareDownload.cpp Outdated Show resolved Hide resolved
src/fileshelter/ui/ShareEdit.cpp Outdated Show resolved Hide resolved
@andymarden
Copy link
Contributor Author

Done and pushed again - also cleared out any spaces and replaced with tabs throughout so it is consistent.

@epoupon epoupon merged commit 069fbc5 into epoupon:develop Feb 5, 2024
6 checks passed
@epoupon
Copy link
Owner

epoupon commented Feb 5, 2024

Thanks!

@epoupon epoupon added this to the v6.2.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants