Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing likelihood() as log_likelihood() and wrapping with logLik() #64

Open
jamesmbaazam opened this issue Sep 12, 2023 · 0 comments
Labels

Comments

@jamesmbaazam
Copy link
Member

I'm now wondering if we should rename the function log_likelihood and remove this argument as in offspring_ll, especially if we eventually want to wrap this by an S3 function for epichains or related objects with the standard name logLik. The only difference is the exp call at the end but the user could also really do that themselves externally.

It would have the benefit that the mentions of "log-likelihood/likelihood" would be shortened to "log-likelihood".

Originally posted by @sbfnk in #58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant