Skip to content

Conversation

@athowes
Copy link
Collaborator

@athowes athowes commented Feb 19, 2025

Description

This is a draft PR to close #536.

Looking at the linting errors, I think they're unrelated to changes made here?

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (f5eead1) to head (46ceee2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   94.38%   94.41%   +0.02%     
==========================================
  Files          17       17              
  Lines         837      841       +4     
==========================================
+ Hits          790      794       +4     
  Misses         47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@athowes athowes requested a review from seabbs February 19, 2025 14:20
@athowes athowes marked this pull request as ready for review February 19, 2025 14:20
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think essentially this just makes the progress message overly verbose. See the specific comments for suggestions.

@athowes
Copy link
Collaborator Author

athowes commented Feb 19, 2025

Have made more concise. Feel free to edit / close if preferred

@athowes athowes requested a review from seabbs February 19, 2025 15:30
@athowes
Copy link
Collaborator Author

athowes commented Mar 13, 2025

Shall we merge or close this @seabbs?

@athowes
Copy link
Collaborator Author

athowes commented Mar 20, 2025

Closing for now.

@athowes athowes closed this Mar 20, 2025
@seabbs
Copy link
Contributor

seabbs commented Mar 20, 2025

sorry missed the question here. I will circle back to this next time I do a block of epidist dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible clearer Inf relative observation time message

3 participants