-
Notifications
You must be signed in to change notification settings - Fork 7
Issue #536: Setting the threshold to Inf message #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 94.38% 94.41% +0.02%
==========================================
Files 17 17
Lines 837 841 +4
==========================================
+ Hits 790 794 +4
Misses 47 47 ☔ View full report in Codecov by Sentry. |
seabbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think essentially this just makes the progress message overly verbose. See the specific comments for suggestions.
|
Have made more concise. Feel free to edit / close if preferred |
|
Shall we merge or close this @seabbs? |
|
Closing for now. |
|
sorry missed the question here. I will circle back to this next time I do a block of epidist dev |
Description
This is a draft PR to close #536.
Looking at the linting errors, I think they're unrelated to changes made here?
Checklist